Sell every swarm-launched token in your wallet for ${IMD_SYMBOL} in one transaction. A 2% fee goes to the treasury.
","title":"taste: the hero line promises 'one transaction' while the flow signs one approval per token plus the sale"},{"citation":"resolved","description":"Now: confirmSale sets progress to the sign step before executeSale runs, and executeSale first reads each token's allowance (sweep.ts lines 235-238) and only then reports the approve steps. For that interval the status line tells the visitor to confirm the sale in their wallet when no wallet prompt exists yet, and then the text changes to 'Approve X in your wallet (1 of N)…'. Change to: add `{ step: \"check\" }` to Progress in sweep.ts, render it in progressText as 'Checking approvals…', and set that as the initial progress here. Why: every state says only what the app knows, and a wallet prompt the visitor is told to look for and cannot find is the kind of flicker that makes people re-click.","line":86,"path":"web/src/App.tsx","reproduction":"At 390: connect a wallet holding a registered sellable token with no allowance to SwarmExit, press Sell all, then press 'Sell 1 token'. The status line under the plan reads 'Confirm the sale in your wallet…' for the duration of the allowance eth_call, then switches to 'Approve X in your wallet (1 of 1)…'. Traced in source: App.tsx line 86 runs before sweep.ts line 236 (allowance read) and line 241 (first approve progress).","severity":"low","snippet":" setSale({ ...sale, error: null, progress: { step: \"sign\", batch: 1, batches: 1 } });","title":"bug: the dialog says 'Confirm the sale in your wallet…' while it is still reading allowances"},{"citation":"resolved","description":"Now: every token that is not sellable gets the pill 'No sell route found', and the note beneath it (line 40) prints `${routeLabel}: ${STATUS_TEXT[status]}`, so a token whose route exists but whose quote fails reads 'No sell route found' over 'Uniswap V2 to IMD: Price impact too high'. The two lines contradict each other. Change to: keep 'No sell route found' when `t.route === null`; when a route exists, make the pill 'Not sellable' and keep the note. Why: the brief greys out 'the tokens for which no sell route is identified'; a token with a route that cannot be used today is a different case and the label should say what the contract said.","line":39,"path":"web/src/components/TokenList.tsx","reproduction":"At 390 or 1440: connect a wallet holding a registered token with a configured route whose preview status is QuoteFailed, BelowMinimum, SaleWouldFail or ImpactTooHigh (STATUS_TEXT indexes 5 to 8 in sweep.ts). The Status cell shows the pill 'No sell route found' and, directly under it, 'Uniswap V2 to IMD: Price impact too high' (or the matching status text).","severity":"low","snippet":" No sell route found","title":"taste: the 'No sell route found' pill sits over a note that names the route"},{"citation":"resolved","description":"Now: the status paragraph is always rendered and keeps 1.5em even when empty, and the panel grid adds its 16px gap above it, so before anything has happened the panel ends 37px below 'Connect a wallet to start.' with nothing in that space, at every width. Change to: `.status-line:empty { min-height: 0; margin-block-start: calc(-1 * var(--space-4)); }` so the live region stays in the tree for screen readers but takes no space until it has text; the panel's bottom padding then closes up to the hint. Why: a hole where nothing is said reads as something missing; the probe's chrome and layout checks pass, this is polish.","line":232,"path":"web/src/styles.css","reproduction":"At 390 (Chromium, dist/ served locally): the hint 'Connect a wallet to start.' ends at y=499.8, the empty .status-line box is 21px tall at y=515.8, and the panel's border ends at y=553.8, so 54px of panel sit under the last text, 37px of it blank beyond the normal 16px padding. The same blank band is visible in test/scratch/taste/shots/390.png and 1440.png under the three buttons.","severity":"low","snippet":".status-line {\n min-height: 1.5em;\n font-size: var(--text-sm);\n color: var(--color-text-secondary);\n}","title":"taste: the summary panel reserves an empty status line and a gap under its buttons"}],"hash":"978dc4a579d24a14d7ab39e5b6d9fcb6fe22b35225173526f207dd6234016a8e","nodeId":"3c2b4a9d-66a7-4065-81c0-b30a45b39b8f","outcome":"completed","summary":"All six snippets now match the tree, the scratch folder is removed, and the working tree holds only the findings file. The review is complete.\n\n| Area | Count |\n| --- | --- |\n| Brief requirements | 10 met, 0 missing, 0 faked (2 also need the requester) |\n| Broken features | 0 (one wrong state message, medium) |\n| Product on the first screen at 390 | yes |\n| taste@1 checks passed | 16 of 16 |\n| Copy findings | 2 |\n| Share card | present: title, favicon, og:title, og:image, description |\n\n**Requirements, quoted**\n\n1. \"called swarmsweep\": met, the header brand and the page title in web/src/App.tsx:140.\n2. \"connect his wallet ... identifies and lists all the swarm released tokens\": met in the build via the connect sheet and previewAll feeding the token table. Needs the requester: the live contract has zero registered tokens, so nothing lists until the owner registers them.\n3. \"sell route for each token ... number of tokens and USD value\": met, the Status pill names the route and the Balance and Value columns show both (web/src/components/TokenList.tsx:105). Needs the requester: the IMD route and ETH/USD feed are unset on chain, so the site honestly shows \"USD n/a\".\n4. \"greyed out with 'no sell route found'\": met, the dim row and muted pill at TokenList.tsx:39.\n5. \"sell all ... select specific tokens ... sell selected\": met, both buttons and per-row checkboxes in App.tsx:171.\n6. \"confirmation box ... list of tokens ... total $IMD the user will receive\": met, the plan table and \"You receive\" row in web/src/components/ConfirmDialog.tsx:52.\n7. \"deduct 2% fee ... 0xFC3a...\": met, enforced by the contract and shown with the treasury link in ConfirmDialog.tsx:97.\n8. \"failed txn, refund the original tokens\": met, the contract refunds in the same transaction and the site shows the refund reason and a claim button for held refunds.\n9. \"user pays the gas fee\": met, the visitor signs every approval and sale, and the dialog says so.\n10. \"sold / unsold in green and red\": met, the ok and bad pills in TokenList.tsx:21 and TokenList.tsx:31.\n\nThe site is a one-screen sell desk whose one idea is a white ledger panel on warm grey with a single deep-blue action.\n\n**Findings written to .imd-findings.json**\n\n- **Medium, accessibility.** Greyed rows paint the balance, name and address at 2.88:1 contrast. Use the secondary grey token, which measures 6.0:1.\n- **Medium, bug.** With the registry empty, every visitor reads \"No swarm-launched tokens in this wallet. Nothing to sell.\" The site has not looked at the wallet. The unused registered count should drive a truthful message.\n- **Medium, taste.** The hero line promises \"one transaction\" while the flow signs one approval per token plus the sale. Replacement copy is in the finding.\n- **Low, bug.** The dialog says \"Confirm the sale in your wallet\" before allowances are read, then flips to \"Approve\".\n- **Low, taste.** The \"No sell route found\" pill sits over a note that names the route.\n- **Low, taste.** The summary panel reserves an empty status line under the buttons at every width.\n\nNot verified: WebKit could not launch here because system libraries are missing, so the Safari pass did not run. The ABI check script failed to load its dependencies, but the bundle's contract, IMD and treasury addresses match the deployment record and the network table. No high findings, so this review does not reopen the build.","treeHash":null,"usage":{"cachedInputTokens":850902,"inputTokens":386,"model":"claude-fable-5-1","outputTokens":23865,"runtime":"claude","turns":30,"wallClockMs":362737}},{"artifacts":[],"attempt":1,"bundleHash":"67f2d87f284d9abf8a3d4f138f26877e8fdbd45e9782a28c8ec4fed90423bd9d","device":"b1d937213bbfd9cf","findings":[],"hash":"b0147484d209919b4e6217fab4860738e3648ddc0efff41f540cacb3f6843d16","nodeId":"c47f29fc-52a5-4aba-b33f-8c447da2719b","outcome":"completed","summary":"The SwarmSweep website is built, validated, and committed as `5b0affc` on top of the existing SwarmExit project. The working tree is clean and the Git bundle is about 0.9 MB, well under the 8 MiB limit.\n\n**What was delivered**\n\n- `web/` replaces the old vanilla page with a Vite, React, TypeScript, wagmi and viem app. The ABI is generated from the pinned `src/SwarmExit.sol` and its key-sorted keccak matches the deployment record's abiHash. Addresses and RPCs come only from the deployment and network tables.\n- The page connects a wallet the network's one way (EIP-6963 extensions, \"Open in\" links on phones, Coinbase Smart Wallet), lists every swarm-registered token the wallet holds, names each token's sell route (Uniswap V2, V3 or v4, direct or via ETH), and shows balance, expected IMD and USD value. Tokens the contract cannot sell are greyed out as \"No sell route found\" with the contract's reason.\n- \"Sell all\" or ticking rows and \"Sell selected\" dry-runs the sale, opens a confirmation listing the tokens, the gross IMD, the 2% fee to the treasury and the net the user receives. On confirm the wallet asks for one approval per token and then the sale; the user pays gas. From the receipt each token is marked green \"Sold\" or red \"Unsold\", with the refund explained. Refunds themselves are done by the contract in the same transaction, and a held refund gets a \"Claim refund\" button.\n- `dist/` is the committed export with relative asset URLs, a title, favicon, description, og:title and a rendered og image. `DESIGN.md` documents tokens, typography, components and responsive rules. The README has install, preview, rebuild and validation sections.\n\n**Checks run on the final source**\n\n| Check | Result |\n| --- | --- |\n| tsc typecheck, vite build | pass |\n| ABI hash vs deployment record | match |\n| taste probe at 320, 390, 1440 | 16 of 16 |\n| Playwright interaction script (mocked RPC and wallet) | 86 of 86 |\n\nThe interaction script lives at `web/scripts/interact.mjs` and covers the first screen at 390, keyboard and focus handling, phone links, connect, route identification, greyed rows, USD values, selection, confirmation totals, the approval and sellAll arguments, and the sold and unsold marks. Better Interface review found four issues, all fixed and rechecked, chiefly a header overflow at 320 that broke the address across lines.\n\n**Limitations and notes**\n\n- No real on-chain sale was sent. The live contract currently has no tokens registered and no IMD route or price feed set, so a real wallet sees an empty list and \"USD values unavailable\" until the owner configures it. The site handles both states.\n- WebKit, screen readers, physical devices and 200% zoom were not checked. No tool-managed browser preview existed, so rendered checks used my own Playwright scripts in Chromium.\n- `artifacts/validation.md` and `artifacts/screenshots/` hold the full record. The artifacts directory is excluded from Git by the repository's own exclude rules, so it is left untracked for separate upload. No ignore file was added.\n\nNot delivered: artifacts/screenshots/1440-after-sale.png, artifacts/screenshots/1440-connected.png, artifacts/screenshots/390-after-sale.png, artifacts/screenshots/390-confirm-all.png, artifacts/screenshots/390-connect-sheet.png, artifacts/screenshots/390-connected.png, artifacts/screenshots/390-first-screen.png, artifacts/screenshots/390-phone-sheet.png and 1 more. Under artifacts/, only this step's named outputs leave the machine.","treeHash":"e9fbb9926a567ba1680410fecbf99599deb30d2d","usage":{"cachedInputTokens":5831589,"inputTokens":1314,"model":"claude-fable-5-1","outputTokens":96015,"runtime":"claude","turns":99,"wallClockMs":1316482}}],"verification":[{"checks":[],"detail":"paths and tree verified; no suite was run for this kind of work","evaluation":"structural","profile":"none","status":"accepted","submissionHash":"b0147484d209919b4e6217fab4860738e3648ddc0efff41f540cacb3f6843d16","verifiedTreeHash":"e9fbb9926a567ba1680410fecbf99599deb30d2d","verifierVersion":"0.1.0+8fbf00a5"}]}